containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
22.36k stars 2.31k forks source link

virtiofsd not in path breaks podman start #23127

Open baude opened 3 days ago

baude commented 3 days ago

Issue Description

It seems like the recent addition of virtiofsd broke podman start on fedora. The virtiofsd executable sits in /usr/libexec and is not present in path.

[baude@baudework ~]$ podman machine start
Starting machine "podman-machine-default"
ERRO[0000] process 6160 has not ended                   
Error: failed to find virtiofsd: exec: "virtiofsd": executable file not found in $PATH

Steps to reproduce the issue

Steps to reproduce the issue 1. 2. 3.

Describe the results you received

Describe the results you received

Describe the results you expected

Describe the results you expected

podman info output

If you are unable to run podman info for any reason, please provide the podman version, operating system and its version and the architecture you are running.

Podman in a container

No

Privileged Or Rootless

None

Upstream Latest Release

Yes

Additional environment details

Additional environment details

Additional information

Additional information like issue happens only occasionally or issue happens with a particular architecture or on a particular setting

Luap99 commented 2 days ago

https://github.com/containers/podman/pull/22920#discussion_r1630919819

In general if you want to hard code paths you can add this back but this is horrible as it doesn't scale across distros.

One thing that we should change though is not to lookup in $PATH. This doesn't make sense and the returned error to users is confusing.

afbjorklund commented 1 day ago

Seems to be missing from the build-from-source documentation, but then again so is gvproxy etc.

Upstream isn't clear on where to install:

https://gitlab.com/virtio-fs/virtiofsd

So normally it just ends up in /usr/local/bin.

But /usr/local/libexec is missing from the list...