containers / podman

Podman: A tool for managing OCI containers and pods.
https://podman.io
Apache License 2.0
22.36k stars 2.31k forks source link

machine: Always use --log-file with gvproxy #23130

Open cfergeau opened 2 days ago

cfergeau commented 2 days ago

The logs are not verbose if --debug is not set, and very useful to have if gvproxy exits unexpectedly.

Does this PR introduce a user-facing change?

None
openshift-ci[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [Luap99] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Luap99 commented 2 days ago

@cfergeau You have to rebase your PR to fix the machine test problem

cfergeau commented 2 days ago

@cfergeau You have to rebase your PR to fix the machine test problem

Done, thanks for the advice!