feat(quadlet): log option handling

containers / podman

Podman: A tool for managing OCI containers and pods.

https://podman.io

Apache License 2.0

22.36k stars 2.31k forks source link

feat(quadlet): log option handling #23135

Open breca opened 2 days ago

breca commented 2 days ago

I found that Quadlet didn't currently have support for log options. This merge allows Quadlet to handle log options and correctly pass those values through to podman run for Container and Kube types.

Syntactically consistent with existing parameters:

[Container]
Image=localhost/imagename
LogOpt=path=/var/log/container/mycontainer.json
LogOpt=size=10mb

Does this PR introduce a user-facing change?

Added support for log driver options to Quadlet (https://docs.podman.io/en/latest/markdown/podman-systemd.unit.5.html#logopt)

packit-as-a-service[bot] commented 2 days ago

Ephemeral COPR build failed. @containers/packit-build please check.

breca commented 23 hours ago

Thanks for the PR. Other than my small nit on the documentation all looks great

Updated - cheers

openshift-ci[bot] commented 23 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breca, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/podman/blob/main/OWNERS)~~ [ygalblum] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment