containers / qm

QM is a containerized environment for running Functional Safety qm (Quality Management) software
https://github.com/containers/qm
GNU General Public License v2.0
22 stars 25 forks source link

Add support for SoC separate var partition #518

Closed Yarboa closed 2 months ago

Yarboa commented 2 months ago

Updating tests/e2e/set-ffi-env-e2e to mkfs.ext4 On free sde partiton it finds VROOM-21987

dougsland commented 2 months ago

I don't believe these are related to your change, already exists as we talked. Should be okay to merge as soon you have a final patch.

/tests/ffi/memory (timeout)

Copying config sha256:728d9197c2ef33c51583e7e162d6055d654208c789a54dd033cb82607f81b444
Writing manifest to image destination
Getting image source signatures
Writing manifest to image destination

Maximum test time '20m' exceeded.
Adjust the test 'duration' attribute if necessary.
https://tmt.readthedocs.io/en/stable/spec/tests.html#duration

/tests/ffi/qm-oom-score-adj

Error: OCI runtime error: crun: the requested cgroup controller `pids` is not available
[ INFO  ] PASS: qm.container oom_score_adj value == 500
./test.sh: line 39: [: cat: /proc/0/oom_score_adj: No such file or directory: integer expression expected
[ INFO  ] FAIL: qm containers oom_score_adj != 750. Current value is cat: /proc/0/oom_score_adj: No such file or directory
Shared connection to 13.59.78.82 closed.
dougsland commented 2 months ago

Output from CI/CD also from your patch (pids exists from cgroup2):

Run echo "Checking cgroup version and settings..."
Checking cgroup version and settings...
nodev   cgroup
nodev   cgroup2
cgroup2 on /sys/fs/cgroup type cgroup2 (rw,nosuid,nodev,noexec,relatime,nsdelegate,memory_recursiveprot)
#subsys_name    hierarchy   num_cgroups enabled
cpuset  0   [1](https://github.com/containers/qm/actions/runs/10588279250/job/29340520739?pr=518#step:3:1)09    1
cpu 0   109 1
cpuacct 0   109 1
blkio   0   109 1
memory  0   109 1
devices 0   109 1
freezer 0   109 1
net_cls 0   10[9](https://github.com/containers/qm/actions/runs/10588279250/job/29340520739?pr=518#step:3:10)   1
perf_event  0   [10](https://github.com/containers/qm/actions/runs/10588279250/job/29340520739?pr=518#step:3:11)9   1
net_prio    0   109 1
hugetlb 0   109 1
pids    0   109 1
rdma    0   109 1
misc    0   109 1
Yarboa commented 2 months ago

@dougsland ready to merge, if now comments It seems that tests/ffi/qm-oom-score-adj/test.sh returned. I will open another issue

dougsland commented 2 months ago

The patch is okay to merge now, we can handle the rest in a next patch.