search

containers / skopeo

Work with remote images registries - retrieving information, images, signing content
Apache License 2.0
7.75k stars 756 forks source link

[CI:DOCS] Update dependency golangci/golangci-lint to v1.59.0 #2333

Closed renovate[bot] closed 1 month ago

renovate[bot] commented 1 month ago

Mend Renovate

This PR contains the following updates:

Package Update Change
golangci/golangci-lint minor 1.58.1 -> 1.59.0

Release Notes

golangci/golangci-lint (golangci/golangci-lint) ### [`v1.59.0`](https://togithub.com/golangci/golangci-lint/compare/v1.58.2...v1.59.0) [Compare Source](https://togithub.com/golangci/golangci-lint/compare/v1.58.2...v1.59.0) ### [`v1.58.2`](https://togithub.com/golangci/golangci-lint/blob/HEAD/CHANGELOG.md#v1582) [Compare Source](https://togithub.com/golangci/golangci-lint/compare/v1.58.1...v1.58.2) 1. Updated linters - `canonicalheader`: from 1.0.6 to 1.1.1 - `gosec`: from 2.19.0 to 2.20.0 - `musttag`: from 0.12.1 to 0.12.2 - `nilnil`: from 0.1.8 to 0.1.9 2. Documentation - Improve integrations and install pages

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

â™» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Mend Renovate. View repository job log here.

packit-as-a-service[bot] commented 1 month ago

Ephemeral COPR build failed. @containers/packit-build please check.

lsm5 commented 1 month ago

whoops, validate test failed. Glad this doesn't have merge bot.

lsm5 commented 1 month ago

this PR passes validate test on my rawhide env as is. Can't seem to tell why it's failing on cirrus. @cevich @mtrmac any idea whatsup here?

mtrmac commented 1 month ago

@lsm5 I think it’s the updated golangci-lint: it has deprecated an option. Do you have the upgraded version locally?

mtrmac commented 1 month ago

… except that we don’t actually set that option. Huh.

lsm5 commented 1 month ago

@lsm5 I think it’s the updated golangci-lint: it has deprecated an option. Do you have the upgraded version locally?

ah nope, I was testing with a much older one installed v1.55. My bad.

mtrmac commented 1 month ago

Note to self: The error message was definitely added in the new 1.58.2 , but I can’t see the setting in .golangci.yml

mtrmac commented 1 month ago

For the record, this is a bug in golangci-lint: https://github.com/golangci/golangci-lint/issues/4733 .

The linter returns exit code 0 after the warning, so we do have a way to check for lint failures without failing on this warning (that’s why c/image is reporting the same warning, but not failing).

But this warning about invalid options has helped us notice an obsolete option recently, so I’m reluctant to change hack/validate-lint.sh to ignore the warning.

Let’s wait for a week or so, to see whether golangci-lint releases an update.