Closed giuseppe closed 2 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: giuseppe
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@kolyshkin @mtrmac @rhatdan some more improvements to the cache file
the PR is ready for review
@mtrmac needs another review.
I've fixed your comments, except https://github.com/containers/storage/pull/1870#discussion_r1556134916. What would you like me to do here?
I've fixed your comments, except #1870 (comment). What would you like me to do here?
https://github.com/containers/storage/pull/1870/files#r1557856169 , or perhaps I’m missing something.
@giuseppe This is waiting on you now?
thanks @mtrmac and @kolyshkin. I've addressed your last comments and pushed a new version
/lgtm
Thanks!
The bloom filter itself is useful to reduce page faults with the mmap'ed cache files, as it reduces lookups.
Storing the file as a binary instead reduces the file size considerably, with the
quay.io/giuseppe/zstd-chunked:fedora-{38,39,40}{,-updated}
images I see:before:
after:
so it is ~50% size reduction