search

containers / storage

Container Storage Library
Apache License 2.0
539 stars 234 forks source link

fileutils: make (Le|E)xists return os.PathError #1883

Closed giuseppe closed 2 months ago

giuseppe commented 2 months ago

wrap the returned error in a os.PathError so the error includes the file path.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/storage/blob/main/OWNERS)~~ [giuseppe] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhatdan commented 2 months ago

LGTM

giuseppe commented 2 months ago

@Luap99 @rhatdan anyone wants to drop a /lgtm? :)

Luap99 commented 2 months ago

@Luap99 @rhatdan anyone wants to drop a /lgtm? :)

I don't consider myself a storage maintainer so I am reluctant to merge anything here. Anyhow this change seem trivial enough so I guess I can make a exception.

/lgtm