containers / storage

Container Storage Library
Apache License 2.0
539 stars 234 forks source link

Add support for drop-in config #1885

Open harche opened 2 months ago

harche commented 2 months ago

Helps in use cases where a drop-in config could help by allowing users to update a subsection of the config instead of touching an entire config file.

e.g.

  1. https://github.com/containers/storage/issues/1306
  2. https://github.com/openshift/enhancements/pull/1600/files#diff-10bfa811cdabc678cbfd947dbeaf04b63ebd24e8d9ab5a05c7abbb998cb72f8aR135
  3. https://github.com/kubernetes/enhancements/issues/4191
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harche Once this PR has been reviewed and has the lgtm label, please assign nalind for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/containers/storage/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harche commented 2 months ago

/hold

rhatdan commented 2 months ago

Could you open a [WIP] PR against Podman to test this feature, and make sure it does not break anything in it's ci/cd system.

harche commented 2 months ago

Could you open a [WIP] PR against Podman to test this feature, and make sure it does not break anything in it's ci/cd system.

@rhatdan I opened https://github.com/containers/podman/pull/22484. Most of the jobs were green, apart from the one for the mac. I am not able to trigger the retest of that job, it needs /ok-to-test label.

rhatdan commented 2 months ago

@nalind @giuseppe @saschagrunert @vrothberg PTAL

cgwalters commented 1 month ago

This would be really quite useful to have, it's just completely annoying right now to e.g. enable composefs because one needs to copy all of the storage config.