search

containers / storage

Container Storage Library
Apache License 2.0
539 stars 234 forks source link

archive: always fix mode for root dir with ForceMask #1931

Closed akihikodaki closed 4 weeks ago

akihikodaki commented 1 month ago

We used to override the root directory permission only when the record for the root directory exists in the archive. However, docker.io/ubuntu:jammy-20240427 lacks such a record and not overriding the root directory permission makes all other permission overrides invalid.

rhatdan commented 4 weeks ago

@giuseppe PTAL

rhatdan commented 4 weeks ago

LGTM

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akihikodaki, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/storage/blob/main/OWNERS)~~ [giuseppe] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment