search

containers / storage

Container Storage Library
Apache License 2.0
539 stars 234 forks source link

Trivial patches to minimize patches needed by NetBSD #1935

Closed coypoop closed 4 weeks ago

coypoop commented 1 month ago

Hi folks, I've been patching your repo to build podman on NetBSD. The resulting podman seems to work well enough.

I'd like to minimize the amount of patches needed, a lot of them are about list of supported OSes. (There are some remaining patches that I still have to think about).

rhatdan commented 4 weeks ago

/approve LGTM

rhatdan commented 4 weeks ago

@giuseppe @saschagrunert @nalind @mheon @vrothberg @flouthoc @TomSweeneyRedHat PTAL

nalind commented 4 weeks ago

Thanks! A few notes. Some of these could use the "unix" build constraint that was added in Go 1.19 instead of "!windows", though I don't think we've done that before. Removing homedir_others.go looks fine, since I don't think we care about plan9 and javascript and wasi platforms. This should probably add one or more netbsd targets to the list of targets that the "local-cross" target in the top-level Makefile attempts to compile for, to prevent regressions on this by catching them in CI.

dfr commented 4 weeks ago

Looks good, thanks!

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coypoop, flouthoc, rhatdan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/storage/blob/main/OWNERS)~~ [flouthoc,rhatdan,saschagrunert] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhatdan commented 4 weeks ago

/lgtm