search

containers / storage

Container Storage Library
Apache License 2.0
539 stars 234 forks source link

chunked: change auto merge threshold to 1024 #1937

Closed giuseppe closed 4 weeks ago

giuseppe commented 4 weeks ago

Increase the threshold for auto-merging parts from 128 to 1024. This change aims to reduce the number of parts in an HTTP multi-range request, thus increasing the likelihood that the server will accept the request.

The previous threshold of 128 often resulted in a large number of small ranges, which could lead to HTTP multi-range requests being rejected by servers due to the excessive number of parts.

It partially addresses the reported issue.

Reported-by: https://github.com/containers/storage/issues/1928

rhatdan commented 4 weeks ago

LGTM Should this be configurable?

rhatdan commented 4 weeks ago

@saschagrunert @mheon @vrothberg @mtrmac @nalind PTAL

rhatdan commented 4 weeks ago

/approve /lgtm

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/storage/blob/main/OWNERS)~~ [giuseppe,rhatdan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment