dump: replace unicode package with custom functions

containers / storage

Container Storage Library

Apache License 2.0

539 stars 234 forks source link

dump: replace unicode package with custom functions #1940

Closed giuseppe closed 4 weeks ago

giuseppe commented 4 weeks ago

To avoid a mismatch with the C composefs library that uses isgraph() and isprint(), do not use the unicode package but provide the expected definition for these functions.

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/storage/blob/main/OWNERS)~~ [giuseppe] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

rhatdan commented 4 weeks ago

LGTM

giuseppe commented 4 weeks ago

got 2 LGTMs, can we merge?

mtrmac commented 4 weeks ago

This is still marked as draft.

I suppose the relevant reference is https://github.com/containers/composefs/blob/3d2af03cd1b1eecfdbb38cfb9f6757a4de8fd713/tools/composefs-info.c#L88-L92 ; and that program does not call setlocale.

mtrmac commented 4 weeks ago

/lgtm