search

containers / storage

Container Storage Library
Apache License 2.0
558 stars 239 forks source link

chunked: fix deadlock by always consuming tar-split #1942

Closed giuseppe closed 3 months ago

giuseppe commented 3 months ago

always consume the tar-split data when present to avoid blocking the producer. Previously, the tar-split data was only read when the digest was specified.

commit 6875c9fbcf1cb6e06ee5e363982a059adec9693b introduced the regression.

follow-up for: https://github.com/containers/storage/pull/1936#discussion_r1624617123

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/storage/blob/main/OWNERS)~~ [giuseppe] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhatdan commented 3 months ago

/lgtm

giuseppe commented 3 months ago

/cherrypick release-1.54

openshift-cherrypick-robot commented 3 months ago

@giuseppe: new pull request created: #1945

In response to [this](https://github.com/containers/storage/pull/1942#issuecomment-2147591869): >/cherrypick release-1.54 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.