search

containers / storage

Container Storage Library
Apache License 2.0
558 stars 239 forks source link

pkg/archive.statDifferent(): care about mtime for directories #1962

Closed nalind closed 3 months ago

nalind commented 3 months ago

When considering changes, don't ignore differences between directories when their mtimes are the only thing we check that's changed. This creates a difference in behavior between the vfs and overlay drivers that shows up in build conformance tests, such as in https://github.com/containers/buildah/pull/5492.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/storage/blob/main/OWNERS)~~ [giuseppe,nalind] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhatdan commented 3 months ago

/lgtm