Closed giuseppe closed 3 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: giuseppe
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I was unaware of this whole subsystem until now. This is the thing keeping indicies of chunks that are used for inside-a-file partial pulls?
The changes seem sane superficially.
I was unaware of this whole subsystem until now. This is the thing keeping indicies of chunks that are used for inside-a-file partial pulls?
yes, this is needed to avoid parsing the json metadata files each time we lookup for a digest. In the same cache file we store the files payload digest, the chunks digest and the hard link fingerprint. The hard link fingerprint a digest that is used to find files that can be used for hard links deduplication (payload digest + UID + GID + mode + xattrs).
/lgtm
and fix some issues found with the new tests.