search

containers / storage

Container Storage Library
Apache License 2.0
537 stars 234 forks source link

store: drop remap-[ug]ids #1976

Closed giuseppe closed 6 days ago

giuseppe commented 1 week ago

drop the possibility to configure a remapping for all the layers in the storage.

The feature dates back to the initial fork from Docker, that supported a single user namespace where all the images were pulled. It was never used by the container tools since we have a finer control of the user namespaces.

cgwalters commented 1 week ago

Right, there's no good use case for setting this globally now AFAIK.

While this obviously isn't exhaustive, at least a Github code search doesn't turn up any obvious uses of this in the wild.

(There are a lot of copies of the default...including some from people who are obviously committing the defaults that we write into their home directory into git...which wouldn't exist if we didn't write the defaults into a file at all)

cgwalters commented 1 week ago

/approve

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/containers/storage/blob/main/OWNERS)~~ [giuseppe] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhatdan commented 1 week ago

Would be good to fire off a podman test suite against this change.

giuseppe commented 1 week ago

opened two tests PRs:

giuseppe commented 6 days ago

tests passed. Ready for review

rhatdan commented 6 days ago

/lgtm