search

containers / storage

Container Storage Library
Apache License 2.0
548 stars 237 forks source link

Delete the Windows storage driver? #2009

Open mtrmac opened 1 month ago

mtrmac commented 1 month ago

Ever since 1eba391bd3cde8005087b661a2f07e803ecba390 in Sep 2017 the driver’s test can’t compile because a addAceToSddlDacl function is missing.

Clearly no-one is even trying to make it functional.

Can we remove that code? If we ever did want to add a Windows support, the old code can always be fished out of git.

rhatdan commented 1 month ago

SGTM

nalind commented 3 weeks ago

That call is in the unit test which only run on Windows, so CI doesn't run them. The driver itself compiles, for whatever that's worth.