containers / toolbox

Tool for interactive command line environments on Linux
https://containertoolbx.org/
Apache License 2.0
2.39k stars 208 forks source link

test/system: Silence SC2154 #1378

Closed debarshiray closed 9 months ago

debarshiray commented 9 months ago

Otherwise https://www.shellcheck.net/ would complain:

  Line 343:
  if [ "$status" -ne 0 ]; then
        ^-----^ SC2154 (warning): status is referenced but not assigned.

See: https://www.shellcheck.net/wiki/SC2154

softwarefactory-project-zuul[bot] commented 9 months ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/4a4c499af98749d19e8e351782507ec2

:heavy_check_mark: unit-test SUCCESS in 8m 53s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 31s :heavy_check_mark: unit-test-restricted SUCCESS in 7m 34s :x: system-test-fedora-rawhide FAILURE in 33m 05s :heavy_check_mark: system-test-fedora-38 SUCCESS in 25m 06s :heavy_check_mark: system-test-fedora-37 SUCCESS in 25m 32s

softwarefactory-project-zuul[bot] commented 9 months ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/a800fc90637f409da9483c72c8b39b49

:heavy_check_mark: unit-test SUCCESS in 7m 57s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 26s :heavy_check_mark: unit-test-restricted SUCCESS in 7m 03s :x: system-test-fedora-rawhide FAILURE in 32m 27s :heavy_check_mark: system-test-fedora-38 SUCCESS in 23m 40s :heavy_check_mark: system-test-fedora-37 SUCCESS in 23m 17s

softwarefactory-project-zuul[bot] commented 9 months ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/09a3426e7f434b14ad1fa22cc0440d07

:heavy_check_mark: unit-test SUCCESS in 8m 17s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 28s :heavy_check_mark: unit-test-restricted SUCCESS in 7m 40s :x: system-test-fedora-rawhide FAILURE in 33m 19s :heavy_check_mark: system-test-fedora-38 SUCCESS in 24m 15s :heavy_check_mark: system-test-fedora-37 SUCCESS in 24m 14s

debarshiray commented 9 months ago

There are still some test failures on Fedora Rawhide. For example:

fedora-rawhide | not ok 3 help: Run command 'help' in 145ms
fedora-rawhide | # (from function `assert_line' in file test/system/libs/bats-assert/src/assert.bash, line 479,
fedora-rawhide | #  in test file test/system/002-help.bats, line 45)
fedora-rawhide | #   `assert_line --index 0 --partial "toolbox(1)"' failed
fedora-rawhide | # /usr/bin/man
fedora-rawhide | #
fedora-rawhide | # -- line does not contain substring --
fedora-rawhide | # index     : 0
fedora-rawhide | # substring : toolbox(1)
fedora-rawhide | # line      : troff:<standard input>:33: warning: cannot select font 'C'
fedora-rawhide | # --

I believe these are because of changes in various other components in Fedora 39, which we need to track down one by one and work out a fix.

In the mean time, I am going to temporarily override these failures.