search

containers / toolbox

Tool for interactive command line environments on Linux
https://containertoolbx.org/
Apache License 2.0
2.39k stars 208 forks source link

images/fedora: Tweaks and tests #1384

Closed debarshiray closed 9 months ago

softwarefactory-project-zuul[bot] commented 9 months ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/8fc7fd117aa444fc8987a9991c0f6500

:heavy_check_mark: unit-test SUCCESS in 13m 10s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 5m 55s :heavy_check_mark: unit-test-restricted SUCCESS in 8m 43s :x: system-test-fedora-rawhide FAILURE in 47m 10s :heavy_check_mark: system-test-fedora-38 SUCCESS in 39m 21s :heavy_check_mark: system-test-fedora-37 SUCCESS in 37m 53s

softwarefactory-project-zuul[bot] commented 9 months ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/8883b439a5b04954895ff0ecf2bf2dad

:heavy_check_mark: unit-test SUCCESS in 8m 13s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 56s :heavy_check_mark: unit-test-restricted SUCCESS in 7m 17s :x: system-test-fedora-rawhide FAILURE in 34m 58s :x: system-test-fedora-39 FAILURE in 34m 19s :heavy_check_mark: system-test-fedora-38 SUCCESS in 24m 17s :heavy_check_mark: system-test-fedora-37 SUCCESS in 23m 59s

debarshiray commented 9 months ago

There are still some test failures on Fedora Rawhide and Fedora 39.

For example, these that seem to be because of changes in various other components in Fedora:

fedora-rawhide | not ok 3 help: Run command 'help' in 145ms
fedora-rawhide | # (from function `assert_line' in file test/system/libs/bats-assert/src/assert.bash, line 479,
fedora-rawhide | #  in test file test/system/002-help.bats, line 45)
fedora-rawhide | #   `assert_line --index 0 --partial "toolbox(1)"' failed
fedora-rawhide | # /usr/bin/man
fedora-rawhide | #
fedora-rawhide | # -- line does not contain substring --
fedora-rawhide | # index     : 0
fedora-rawhide | # substring : toolbox(1)
fedora-rawhide | # line      : troff:<standard input>:33: warning: cannot select font 'C'
fedora-rawhide | # --

However, at least these two failures are a fallout from the Fedora 39 Change that made the fedora-toolbox:39 and above images to be generated as part of the nightly composes:

fedora-rawhide | not ok 82 list: Default image in 39783ms
fedora-rawhide | # (from function `assert_line' in file test/system/libs/bats-assert/src/assert.bash, line 479,
fedora-rawhide | #  in test file test/system/102-list.bats, line 99)
fedora-rawhide | #   `assert_line --index 1 --partial "$default_image"' failed
fedora-rawhide | #
fedora-rawhide | # -- line does not contain substring --
fedora-rawhide | # index     : 1
fedora-rawhide | # substring : registry.fedoraproject.org/fedora-toolbox:40
fedora-rawhide | # line      :
fedora-rawhide | # --
fedora-rawhide | #
fedora-rawhide | not ok 83 list: Default image (using --images) in 39062ms
fedora-rawhide | # (from function `assert_line' in file test/system/libs/bats-assert/src/assert.bash, line 479,
fedora-rawhide | #  in test file test/system/102-list.bats, line 117)
fedora-rawhide | #   `assert_line --index 1 --partial "$default_image"' failed
fedora-rawhide | #
fedora-rawhide | # -- line does not contain substring --
fedora-rawhide | # index     : 1
fedora-rawhide | # substring : registry.fedoraproject.org/fedora-toolbox:40
fedora-rawhide | # line      :
fedora-rawhide | # --
fedora-rawhide | #

The images are now built with Image Factory with Kickstarts and Pungi instead of with OpenShift Build Service cluster from Dockerfiles. During that migration we lost the com.github.containers.toolbox LABEL from the images and they no longer show up as Toolbx images.

I submitted some pull requests to address that:

In the mean time, while we track down and fix these failures, I am going to temporarily override these failures.