search

containers / toolbox

Tool for interactive command line environments on Linux
https://containertoolbx.org/
Apache License 2.0
2.38k stars 208 forks source link

cmd/initContainer: Defend against insufficient resources for inotify(7) #1422

Closed debarshiray closed 6 months ago

debarshiray commented 6 months ago

Currently, inotify(7) is used to keep /etc/timezone inside the Toolbx container synchronized with the host operating system's /etc/localtime. However, /etc/timezone is only there for compatibility with Java. The vast majority of non-ancient code bases use /etc/localtime, which does not need inotify(7) to stay synchronized.

Therefore, it's not worth preventing the container from starting when the operating system is suffering from a shortage of resources needed for inotify(7). Especially because this shortage can be caused by a bug in another program that's consuming too many inotify(7) instances and watches.

https://github.com/containers/toolbox/issues/1329

softwarefactory-project-zuul[bot] commented 6 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/2e45306ffb104c61b8a48a6b9beb4b49

:heavy_check_mark: unit-test SUCCESS in 9m 31s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 08s :heavy_check_mark: unit-test-restricted SUCCESS in 7m 59s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 33m 32s :heavy_check_mark: system-test-fedora-39 SUCCESS in 32m 18s :heavy_check_mark: system-test-fedora-38 SUCCESS in 32m 01s