search

containers / toolbox

Tool for interactive command line environments on Linux
https://containertoolbx.org/
Apache License 2.0
2.38k stars 208 forks source link

cmd: Let the terminal know the active container on all host OSes #1429

Closed debarshiray closed 6 months ago

debarshiray commented 6 months ago

Prompt is a new terminal emulation application [1] designed for a container-oriented desktop that implements the OSC 777 escape sequence to track and preserve the user's current Toolbx container [2]. Hence, Fedora's fork of GNOME Terminal is no longer the only one to offer this.

Therefore, it's time let users of all host operating systems enjoy this feature.

This reverts commits a3e8d8d12bac6dd63010b71c6e091486fb585f37 and 3a96feba478448cd0c5628238619c3805c6aca1e.

[1] https://gitlab.gnome.org/chergert/prompt

[2] https://gitlab.freedesktop.org/terminal-wg/specifications/-/issues/17

https://github.com/containers/toolbox/issues/218

softwarefactory-project-zuul[bot] commented 6 months ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/cd770412fcd84ffb86ce21465cc178ac

:x: unit-test FAILURE in 7m 02s :x: unit-test-migration-path-for-coreos-toolbox FAILURE in 2m 37s :x: unit-test-restricted FAILURE in 6m 21s :x: system-test-fedora-rawhide FAILURE in 30m 42s :x: system-test-fedora-39 FAILURE in 26m 48s :x: system-test-fedora-38 FAILURE in 29m 22s

softwarefactory-project-zuul[bot] commented 6 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/a6329956853b42998c08aaf15f855f01

:heavy_check_mark: unit-test SUCCESS in 6m 22s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 06s :heavy_check_mark: unit-test-restricted SUCCESS in 6m 18s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 28m 20s :heavy_check_mark: system-test-fedora-39 SUCCESS in 26m 48s :heavy_check_mark: system-test-fedora-38 SUCCESS in 28m 14s

HarryMichal commented 6 months ago

Do we know how does this behave in non-VTE/non-patched terminal emulators? Does it change the behaviour of the emulator or is it just ignored?

debarshiray commented 6 months ago

Do we know how does this behave in non-VTE/non-patched terminal emulators? Does it change the behaviour of the emulator or is it just ignored?

I believe VTE just ignores the unknown escape sequence.

This is this branch on Ubuntu 23.10 with a GNOME Terminal that doesn't preserve the current Toolbx container:

image

softwarefactory-project-zuul[bot] commented 6 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/25763fc164f5463f975c4fb5566c97ec

:heavy_check_mark: unit-test SUCCESS in 7m 38s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 30s :heavy_check_mark: unit-test-restricted SUCCESS in 6m 29s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 30m 24s :heavy_check_mark: system-test-fedora-39 SUCCESS in 29m 45s :heavy_check_mark: system-test-fedora-38 SUCCESS in 29m 48s