search

containers / toolbox

Tool for interactive command line environments on Linux
https://containertoolbx.org/
Apache License 2.0
2.38k stars 208 forks source link

build: Do not use use auto dependencies for shell completion scripts #1442

Closed valentindavid closed 5 months ago

valentindavid commented 5 months ago

It is difficult for downstream to track dependencies when they are automatic. This results in shell completion scripts not being installed in packages because builders do not have the right dependency. This commit adds meson feature arguments to guard those dependencies so that downstream distributions can use -Dauto_features=enabled.

For more explanation, see rule #3 of: https://blogs.gnome.org/mcatanzaro/2022/07/15/best-practices-for-build-options/

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/43335055e15b4bb3b70a00622543fa76

:heavy_check_mark: unit-test SUCCESS in 6m 56s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 41s :heavy_check_mark: unit-test-restricted SUCCESS in 6m 01s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 30m 07s :heavy_check_mark: system-test-fedora-39 SUCCESS in 28m 45s :heavy_check_mark: system-test-fedora-38 SUCCESS in 29m 22s

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/f67c23dbde724c63bb55c9b23ef29691

:heavy_check_mark: unit-test SUCCESS in 6m 52s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 36s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 54s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 49m 50s :heavy_check_mark: system-test-fedora-39 SUCCESS in 46m 31s :heavy_check_mark: system-test-fedora-38 SUCCESS in 35m 47s

debarshiray commented 5 months ago

Rebased, added a link to this pull request and merged. Thanks, again.