containers / toolbox

Tool for interactive command line environments on Linux
https://containertoolbx.org/
Apache License 2.0
2.38k stars 208 forks source link

images/fedora: Add cracklib-dicts to Fedora 38 and 39 #1444

Closed debarshiray closed 5 months ago

debarshiray commented 5 months ago

Currently, the libpwquality package mentions cracklib-dicts as a weak dependency [1,2]. However, the libpwquality package is part of the fedora base image, which doesn't include weak dependencies [3], and that leads to cracklib-dicts going missing.

The absence of the cracklib-dicts package causes various operations that go through libpwquality (eg., pwmake(1)) to fail [1], and sometimes in confusing ways [4].

[1] Fedora libpwquality commit f84a5e3ba6c166e5 https://src.fedoraproject.org/rpms/libpwquality/c/f84a5e3ba6c166e5 https://bugzilla.redhat.com/show_bug.cgi?id=2158891

[2] Fedora libpwquality commit 303154338d6d3650 https://src.fedoraproject.org/rpms/libpwquality/c/303154338d6d3650 https://bugzilla.redhat.com/show_bug.cgi?id=2006063

[3] fedora-kickstarts commit 1c39c0adb0d44866 https://pagure.io/fedora-kickstarts/c/1c39c0adb0d44866 https://pagure.io/fedora-kickstarts/pull-request/551 https://pagure.io/releng/issue/8530

[4] https://github.com/libpwquality/libpwquality/pull/85

https://github.com/containers/toolbox/issues/1351

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/9b73c8f61b3846c6bd3a29d09b845536

:heavy_check_mark: unit-test SUCCESS in 8m 03s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 27s :heavy_check_mark: unit-test-restricted SUCCESS in 4m 01s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 42m 49s :heavy_check_mark: system-test-fedora-39 SUCCESS in 32m 43s :heavy_check_mark: system-test-fedora-38 SUCCESS in 37m 41s

softwarefactory-project-zuul[bot] commented 5 months ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/2bd478d945504ab3a1228c820fba6342

:heavy_check_mark: unit-test SUCCESS in 4m 56s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 17s :heavy_check_mark: unit-test-restricted SUCCESS in 3m 50s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 29m 32s :heavy_check_mark: system-test-fedora-39 SUCCESS in 29m 07s :heavy_check_mark: system-test-fedora-38 SUCCESS in 32m 57s