Closed notfirefox closed 7 months ago
Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/304c3f25c4504232a58dc1ed911a7838
:heavy_check_mark: unit-test SUCCESS in 4m 37s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 10s :heavy_check_mark: unit-test-restricted SUCCESS in 3m 50s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 35m 29s :heavy_check_mark: system-test-fedora-39 SUCCESS in 34m 02s :heavy_check_mark: system-test-fedora-38 SUCCESS in 36m 12s
Thanks for figuring this out, @notfirefox ! Could you please correct your Git authorship information with your full name and a real email address, unless you are worried about privacy?
I'd prefer to keep the authorship information as it is because of privacy concerns.
Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/4aa2991cdfa4460697734c222c3470c5
:heavy_check_mark: unit-test SUCCESS in 4m 45s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 35s :heavy_check_mark: unit-test-restricted SUCCESS in 3m 51s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 34m 18s :heavy_check_mark: system-test-fedora-39 SUCCESS in 34m 45s :heavy_check_mark: system-test-fedora-38 SUCCESS in 36m 06s
Thanks for figuring this out, @notfirefox ! Could you please correct your Git authorship information with your full name and a real email address, unless you are worried about privacy?
I'd prefer to keep the authorship information as it is because of privacy concerns.
I see. A few things:
The Signed-off-by
trailer has no meaning without a real full name and email address.
I could have made an exception for a one line change, like adding an environment variable, because it would be legally insignificant. However, that's no longer the case with this pull request after the addition of the tests. :)
We need a real full name and email address for tracking copyright holders in case a licensing issue crops up. Note how projects as diverse as GCC, GnuPG, Linux and Podman don't allow anonymous or pseudonymous contributions.
Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/0b967ea5ea934a229f9a6d3104faaa61
:heavy_check_mark: unit-test SUCCESS in 4m 36s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 29s :heavy_check_mark: unit-test-restricted SUCCESS in 3m 49s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 33m 15s :heavy_check_mark: system-test-fedora-39 SUCCESS in 34m 46s :heavy_check_mark: system-test-fedora-38 SUCCESS in 33m 18s
@debarshiray DCO related issues should be resolved now.
Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/ff1aaee80def465b8062db370657f522
:heavy_check_mark: unit-test SUCCESS in 5m 33s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 48s :heavy_check_mark: unit-test-restricted SUCCESS in 4m 01s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 31m 52s :heavy_check_mark: system-test-fedora-39 SUCCESS in 36m 07s :heavy_check_mark: system-test-fedora-38 SUCCESS in 34m 04s
Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/ea7231e82c1f497b866bf231a2ad9aec
:heavy_check_mark: unit-test SUCCESS in 4m 47s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 47s :heavy_check_mark: unit-test-restricted SUCCESS in 3m 45s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 34m 30s :heavy_check_mark: system-test-fedora-39 SUCCESS in 35m 30s :heavy_check_mark: system-test-fedora-38 SUCCESS in 35m 02s
Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/275ec937e21046a7a59802396d0aacef
:heavy_check_mark: unit-test SUCCESS in 4m 39s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 36s :heavy_check_mark: unit-test-restricted SUCCESS in 3m 51s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 55m 46s :heavy_check_mark: system-test-fedora-39 SUCCESS in 55m 30s :heavy_check_mark: system-test-fedora-38 SUCCESS in 56m 22s
Thanks for working on this, @notfirefox ; and for reconsidering the privacy issues! Much appreciated.
As discussed here.
KONSOLE_VERSION
to the list of preserved environment variablesCloses #1449