containers / toolbox

Tool for interactive command line environments on Linux
https://containertoolbx.org/
Apache License 2.0
2.38k stars 208 forks source link

actions/ubuntu-tests makes use of Node 16 which is end of life (EOL) #1459

Closed notfirefox closed 3 months ago

notfirefox commented 4 months ago

Is your feature request related to a problem? Please describe. Node 16 is being deprecated, here is a quick excerpt from GitHub:

Node 16 has reached its end of life, prompting us to initiate its deprecation process for GitHub Actions. Our plan is to transition all actions to run on Node 20 by Spring 2024. [...] Starting October 23rd, workflows containing actions running on Node 16 will display a warning to alert users about the upcoming migration.

Currently when running ubuntu-jammy-tests, we get the following warning:

ubuntu-jammy-tests Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Describe the solution you'd like Update ubuntu-tests so that it uses checkout@v4 instead of checkout@v3.

Describe alternatives you've considered None

Additional context According to this changelog, it should be sufficient to bump the version of actions/checkout to 4.

debarshiray commented 4 months ago

Thanks for the heads-up, @notfirefox ! Would you have time to submit a pull request?

notfirefox commented 4 months ago

Thanks for the heads-up, @notfirefox ! Would you have time to submit a pull request?

See https://github.com/containers/toolbox/pull/1466

debarshiray commented 3 months ago

This blog post says:

Starting October 23rd, workflows containing actions running on Node 16 will display a warning to alert users about the upcoming migration.

However, I can't spot any warnings from the ubuntu-tests workflow. I am merely curious, because that way I will know how to look out for similar problems in the future.

notfirefox commented 3 months ago

@debarshiray https://github.com/containers/toolbox/actions/runs/8218105705

image

debarshiray commented 3 months ago

Aha, I see. I had to click the Summary on the left. Today I learnt. :)