cmd/run, pkg/podman: Split Inspect() into two for containers and images

containers / toolbox

Tool for interactive command line environments on Linux

https://containertoolbx.org/

Apache License 2.0

2.38k stars 208 forks source link

cmd/run, pkg/podman: Split Inspect() into two for containers and images #1487

Closed debarshiray closed 1 month ago

debarshiray commented 1 month ago

In future, it will be good if podman.Inspect() returned a Container or Image object instead of a []map[string]interface{} that the caller has to parse. This is because parsing the []map[string]interface{} involves tracking changes in the JSON output by different Podman versions, and it's better to limit such details to the podman package.

Splitting podman.Inspect() into two separate functions for containers and images is one way of achieving that.

softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/9739883057ad4fb1980a0494b3d49201

:heavy_check_mark: unit-test SUCCESS in 6m 46s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 14s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 38s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 36m 42s :heavy_check_mark: system-test-fedora-40 SUCCESS in 35m 38s :heavy_check_mark: system-test-fedora-39 SUCCESS in 36m 24s :heavy_check_mark: system-test-fedora-38 SUCCESS in 35m 43s