containers / toolbox

Tool for interactive command line environments on Linux
https://containertoolbx.org/
Apache License 2.0
2.38k stars 208 forks source link

cmd/run: Optimize 'enter' and 'run' for already running containers, and turn IsToolboxContainer() into Container.IsToolbx() #1491

Closed debarshiray closed 1 month ago

debarshiray commented 1 month ago

https://github.com/containers/toolbox/issues/1070

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/71dc5cb75937401896b684d41b607aa4

:heavy_check_mark: unit-test SUCCESS in 6m 55s :x: unit-test-migration-path-for-coreos-toolbox FAILURE in 3m 39s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 41s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 42m 21s :heavy_check_mark: system-test-fedora-40 SUCCESS in 40m 34s :heavy_check_mark: system-test-fedora-39 SUCCESS in 34m 17s :heavy_check_mark: system-test-fedora-38 SUCCESS in 40m 40s

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/a4431f5aa76b4d488edea5b135479c95

:heavy_check_mark: unit-test SUCCESS in 7m 06s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 27s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 58s :x: system-test-fedora-rawhide FAILURE in 39m 33s :x: system-test-fedora-40 FAILURE in 37m 26s :x: system-test-fedora-39 FAILURE in 37m 22s :x: system-test-fedora-38 FAILURE in 34m 09s

debarshiray commented 1 month ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/a4431f5aa76b4d488edea5b135479c95

system-test-fedora-rawhide FAILURE in 39m 33s ❌ system-test-fedora-40 FAILURE in 37m 26s ❌ system-test-fedora-39 FAILURE in 37m 22s ❌ system-test-fedora-38 FAILURE in 34m 09s

TASK [Run system tests]
...
fedora-rawhide | 1..343
fedora-rawhide | # test suite: Set up
...
fedora-rawhide | not ok 179 rm: Try to remove a non-existent container in 462ms
fedora-rawhide | # (from function `assert_output' in file test/system/libs/bats-assert/src/assert.bash, line 255,
fedora-rawhide | #  in test file test/system/106-rm.bats, line 37)
fedora-rawhide | #   `assert_output "Error: failed to inspect container $container_name"' failed
fedora-rawhide | #
fedora-rawhide | # -- output differs --
fedora-rawhide | # expected : Error: failed to inspect container nonexistentcontainer
fedora-rawhide | # actual   : Error: failed to invoke podman(1)
fedora-rawhide | # --
fedora-rawhide | #
softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/dda1492433f7453d8757bac23d9af918

:heavy_check_mark: unit-test SUCCESS in 7m 05s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 30s :heavy_check_mark: unit-test-restricted SUCCESS in 6m 04s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 36m 45s :heavy_check_mark: system-test-fedora-40 SUCCESS in 34m 25s :heavy_check_mark: system-test-fedora-39 SUCCESS in 34m 41s :heavy_check_mark: system-test-fedora-38 SUCCESS in 35m 21s

softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/9ba8497b17ed4da9892a9b40ea77b228

:heavy_check_mark: unit-test SUCCESS in 6m 42s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 31s :heavy_check_mark: unit-test-restricted SUCCESS in 6m 02s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 36m 20s :heavy_check_mark: system-test-fedora-40 SUCCESS in 35m 59s :heavy_check_mark: system-test-fedora-39 SUCCESS in 37m 07s :heavy_check_mark: system-test-fedora-38 SUCCESS in 36m 24s

softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/d98ee29bf25744b08623c2ef997771c6

:heavy_check_mark: unit-test SUCCESS in 6m 50s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 22s :heavy_check_mark: unit-test-restricted SUCCESS in 4m 46s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 37m 35s :heavy_check_mark: system-test-fedora-40 SUCCESS in 35m 46s :heavy_check_mark: system-test-fedora-39 SUCCESS in 34m 38s :heavy_check_mark: system-test-fedora-38 SUCCESS in 36m 02s

softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/8935764a9ede4fd8a17d41a1f7a8be81

:heavy_check_mark: unit-test SUCCESS in 6m 28s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 06s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 54s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 41m 28s :heavy_check_mark: system-test-fedora-40 SUCCESS in 36m 03s :heavy_check_mark: system-test-fedora-39 SUCCESS in 36m 25s :heavy_check_mark: system-test-fedora-38 SUCCESS in 35m 34s

softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/dc12f0bb935340f9a0c7aec0d2dc1159

:heavy_check_mark: unit-test SUCCESS in 7m 02s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 23s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 47s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 36m 12s :heavy_check_mark: system-test-fedora-40 SUCCESS in 33m 54s :heavy_check_mark: system-test-fedora-39 SUCCESS in 34m 38s :heavy_check_mark: system-test-fedora-38 SUCCESS in 34m 22s