softwarefactory-project-zuul[bot]
commented
1 month ago Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/e071ec50213946ed8fa6e0099e6c5eed
:heavy_check_mark: unit-test SUCCESS in 6m 42s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 35s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 53s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 35m 29s :heavy_check_mark: system-test-fedora-40 SUCCESS in 32m 41s :heavy_check_mark: system-test-fedora-39 SUCCESS in 33m 17s :heavy_check_mark: system-test-fedora-38 SUCCESS in 32m 10s
debarshiray
Currently, the
enterandruncommands poll at one second intervals to check if the Toolbx container's entry point has created the initialization stamp file to indicate that the container has been initialized. This came from the POSIX shell implementation [1], where it was relatively easier to poll than to useinotify(7)to monitor the file system.The problem with polling is that the interval is always going to be either too short and waste resources or too long and cause delays. The current one second interval is sufficiently long to add a noticeable delay to the
enterandruncommands.It will be better to use
inotify(7)to monitor the file system, which is quite easy to do with the Go implementation, so that the commands can proceed as soon as the initialization stamp file is available, instead of waiting for the polling interval to pass.There's a fallback to polling, as before, when the operating system is suffering from a shortage of resources needed for
inotify(7). This code path can be forced through theTOOLBX_RUN_USE_POLLINGenvironment variable for testing. Setting this environment variable disables some code to ensure that the polling ticker is actually used, because, otherwise, the race between the creation and detection of the initialization stamp file makes it difficult to test the fallback.[1] Commit d3e0f3df06d3f5ac https://github.com/containers/toolbox/commit/d3e0f3df06d3f5ac https://github.com/containers/toolbox/pull/305
https://github.com/containers/toolbox/issues/1070