search

containers / toolbox

Tool for interactive command line environments on Linux
https://containertoolbx.org/
Apache License 2.0
2.38k stars 208 forks source link

Images: Add Ubuntu 24.04 (new LTS) and remove Ubuntu 23.04 (EOL interim) #1499

Closed Jmennius closed 4 weeks ago

Jmennius commented 1 month ago

Quite simple, it does seem to work :)

Fixes: #1481

softwarefactory-project-zuul[bot] commented 1 month ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/4c1fb35fc68c4911945bade19e57cfe8

:heavy_check_mark: unit-test SUCCESS in 7m 13s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 47s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 51s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 38m 41s :heavy_check_mark: system-test-fedora-40 SUCCESS in 36m 52s :heavy_check_mark: system-test-fedora-39 SUCCESS in 36m 56s :heavy_check_mark: system-test-fedora-38 SUCCESS in 36m 38s

travier commented 4 weeks ago

Thanks!

travier commented 4 weeks ago

Ah, my bad, I missed that this was the general toolbox repo and I think here we keep all versions of the images (i.e. we don't remove EOL'ed ones) in the repo.

travier commented 4 weeks ago

Could you make a follow-up PR to re-add the EOL'ed 23.04 ones but not build them? Thanks

Jmennius commented 4 weeks ago

Ah, my bad, I missed that this was the general toolbox repo and I think here we keep all versions of the images (i.e. we don't remove EOL'ed ones) in the repo.

oh really? I think there was one that we have removed as well before... (22.10 in #1416 - should I bring that one back as well?)

travier commented 4 weeks ago

Ah, good point. I'll let @debarshiray decide. I don't mind either way, it's all in the history.

debarshiray commented 4 weeks ago

Thanks for taking care of this, @Jmennius @travier @Foxboron !

Ah, my bad, I missed that this was the general toolbox repo and I think here we keep all versions of the images (i.e. we don't remove EOL'ed ones) in the repo.

I don't have a strong opinion. I keep the sources of the EOL:ed fedora-toolbox images around because I sometimes find them useful to track down some historical factoid. If some image maintainer wants to remove them, then so be it. :)