search

containers / toolbox

Tool for interactive command line environments on Linux
https://containertoolbx.org/
Apache License 2.0
2.38k stars 208 forks source link

profile.d/toolbox.sh: set PS1 as explicit string constants #1514

Open juhp opened 5 days ago

juhp commented 5 days ago

Since the PS1 strings are constants there is no need to use printf and embed binary color codes, which also makes it hard to match on toolbox PS1.

I tested these in bash and zsh locally and they seem to work fine.

softwarefactory-project-zuul[bot] commented 5 days ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/cc15eb9e07594ce98090ab22ec85eaa3

:x: unit-test FAILURE in 6m 05s :x: unit-test-migration-path-for-coreos-toolbox FAILURE in 3m 06s :x: unit-test-restricted FAILURE in 5m 52s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 38m 42s :heavy_check_mark: system-test-fedora-40 SUCCESS in 35m 13s :heavy_check_mark: system-test-fedora-39 SUCCESS in 35m 53s :heavy_check_mark: system-test-fedora-38 SUCCESS in 33m 56s

juhp commented 2 days ago

(I dropped the zsh PS1 change, since shellcheck doesn't like $'...' quoting :man_shrugging:)

softwarefactory-project-zuul[bot] commented 2 days ago

Build succeeded. https://softwarefactory-project.io/zuul/t/local/buildset/9878af48e57e426dbe83b245a218fce4

:heavy_check_mark: unit-test SUCCESS in 5m 34s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 39s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 39s :heavy_check_mark: system-test-fedora-rawhide SUCCESS in 37m 08s :heavy_check_mark: system-test-fedora-40 SUCCESS in 36m 28s :heavy_check_mark: system-test-fedora-39 SUCCESS in 37m 00s :heavy_check_mark: system-test-fedora-38 SUCCESS in 35m 08s