containers / toolbox

Tool for interactive command line environments on Linux
https://containertoolbx.org/
Apache License 2.0
2.58k stars 219 forks source link

Fish Shell Completions #1516

Closed er2 closed 1 month ago

er2 commented 4 months ago

Toolbox would be much more enjoyable to use with shell auto-completions.

It's much easier to hit tab with

toolbox create --distro ␉

and get available distros than to get an error and have to pull up docs.

I picked ubuntu since debian wasn't available. Then I needed a release. It would have been friendlier to suggest the latest LTS and ask me to confirm, BTW.

The syntax for release isn't obvious. I expected --release to take a nickname like jammy. Autocompletion would make this a non-issue.

debarshiray commented 1 month ago

Toolbx has been shipping completions for fish since 0.0.99.4.

They do auto-complete --distro with the names of officially supported distributions, but not --release though. Although, the error does give a hint:

$ toolbox create --distro ubuntu --release jammy
Error: invalid argument for '--release'
The release must be in the 'YY.MM' format.
Run 'toolbox --help' for usage.

Do you know of a good way to map the alliterative code names of Ubuntu's releases to their month and year version numbers?

debarshiray commented 1 month ago

I tested with a fresh Fedora Workstation 40 virtual machine and the fish completions do work.

I am going to tentatively close this. Please leave a comment or open a new issue if you think I got it wrong.

Thanks for stopping by! :)

er2 commented 1 month ago

That's fine. I think it's an issue with the Arch package

On Thu, Oct 10, 2024, 5:21 PM Debarshi Ray @.***> wrote:

Closed #1516 https://github.com/containers/toolbox/issues/1516 as completed.

— Reply to this email directly, view it on GitHub https://github.com/containers/toolbox/issues/1516#event-14597503314, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCOKO3O5ASDQOMISEH4Q43Z23VWXAVCNFSM6AAAAABKOSRT3KVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGU4TONJQGMZTCNA . You are receiving this because you authored the thread.Message ID: @.***>

debarshiray commented 1 month ago

That's fine. I think it's an issue with the Arch package

I see. Thanks for the confirmation!