containers / toolbox

Tool for interactive command line environments on Linux
https://containertoolbx.org/
Apache License 2.0
2.59k stars 219 forks source link

Replace `/usr/local/sbin/unminimize` with `unminimize` in apt #1567

Closed tom-reinders closed 1 month ago

tom-reinders commented 1 month ago

Fixes #1566

/usr/local/sbin/unminimize has been remove and has been replaced with unminimize in apt

https://github.com/docker-library/official-images/pull/17708#issuecomment-2407308768 https://discourse.ubuntu.com/t/oracular-oriole-release-notes/44878#unminimize-33

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/d5c6112c13f7412c8bbb53c77ba3ee00

:heavy_check_mark: unit-test SUCCESS in 5m 46s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 56s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 16s :heavy_check_mark: system-test-fedora-rawhide-commands-options SUCCESS in 1h 26m 19s :heavy_check_mark: system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 13m 44s :heavy_check_mark: system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 38m 37s :heavy_check_mark: system-test-fedora-41-commands-options SUCCESS in 1h 22m 10s :x: system-test-fedora-41-runtime-environment TIMED_OUT in 1h 45m 22s :heavy_check_mark: system-test-fedora-40-commands-options SUCCESS in 1h 23m 48s :x: system-test-fedora-40-runtime-environment TIMED_OUT in 1h 45m 21s :heavy_check_mark: system-test-fedora-39-commands-options SUCCESS in 1h 23m 40s :x: system-test-fedora-39-runtime-environment TIMED_OUT in 1h 45m 22s

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/5b3cc271e628470ebd0d0903a2169b75

:heavy_check_mark: unit-test SUCCESS in 5m 49s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 54s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 54s :heavy_check_mark: system-test-fedora-rawhide-commands-options SUCCESS in 1h 14m 04s :heavy_check_mark: system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 20m 57s :heavy_check_mark: system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 33m 06s :heavy_check_mark: system-test-fedora-41-commands-options SUCCESS in 1h 14m 12s :x: system-test-fedora-41-runtime-environment TIMED_OUT in 1h 45m 24s :heavy_check_mark: system-test-fedora-40-commands-options SUCCESS in 1h 14m 09s :x: system-test-fedora-40-runtime-environment TIMED_OUT in 1h 45m 22s :heavy_check_mark: system-test-fedora-39-commands-options SUCCESS in 1h 13m 21s :heavy_check_mark: system-test-fedora-39-runtime-environment SUCCESS in 1h 43m 52s

Jmennius commented 1 month ago

I've reworded and squashed commits, removed .idea gitignore. This is good to go IMO.

Jmennius commented 1 month ago

Hmm, looking at how Github notifies about scheduled workflows...

Notifications for scheduled workflows are sent to the user who initially created the workflow. If a different user updates the cron syntax in the workflow file, subsequent notifications will be sent to that user instead. If a scheduled workflow is disabled and then re-enabled, notifications will be sent to the user who re-enabled the workflow rather than the user who last modified the cron syntax.

So if I want to receive notification I should be the one to be the last editor or enabled of the workflow... this is hilarious, there is no way to set it as a configuration. I'm thinking, with your permission, I can change the authorship on that commit that touches the workflow... but then there is another PR that will soon touch it again :(

softwarefactory-project-zuul[bot] commented 1 month ago

Build failed. https://softwarefactory-project.io/zuul/t/local/buildset/819dbbec81de430788da88a570f50eb4

:heavy_check_mark: unit-test SUCCESS in 5m 46s :heavy_check_mark: unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 07s :heavy_check_mark: unit-test-restricted SUCCESS in 5m 49s :heavy_check_mark: system-test-fedora-rawhide-commands-options SUCCESS in 1h 27m 24s :heavy_check_mark: system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 39m 48s :heavy_check_mark: system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 41m 21s :heavy_check_mark: system-test-fedora-41-commands-options SUCCESS in 1h 30m 06s :x: system-test-fedora-41-runtime-environment TIMED_OUT in 1h 45m 25s :heavy_check_mark: system-test-fedora-40-commands-options SUCCESS in 1h 31m 00s :x: system-test-fedora-40-runtime-environment TIMED_OUT in 1h 45m 30s :heavy_check_mark: system-test-fedora-39-commands-options SUCCESS in 1h 31m 59s :x: system-test-fedora-39-runtime-environment TIMED_OUT in 1h 45m 20s

tom-reinders commented 1 month ago

@Jmennius Where has the fail-fast: false gone?

Jmennius commented 1 month ago

@Jmennius Where has the fail-fast: false gone?

I'll add it to another PR :) In a minute