search

containers / udica

This repository contains a tool for generating SELinux security profiles for containers
GNU General Public License v3.0
488 stars 47 forks source link

Refactor engine-specific handling code to use classes #63

Closed JAORMX closed 4 years ago

JAORMX commented 4 years ago

This is a small refactor that moves the if statements for engine-specific cases in the parsing code to use classes instead.

JAORMX commented 4 years ago

@wrabcak huh... CI seems broken. Anybody looking at this?

Failed to start: Invalid value for field 'resource.disks[0].initializeParams.sourceImage': 'https://www.googleapis.com/compute/v1/projects/libpod-218412/global/images/fedora-31-libpod-6268069335007232'. The referenced image resource cannot be found.
wrabcak commented 4 years ago

Hi @cevich, Can you please check the CI?

THanks, Lukas.

cevich commented 4 years ago

Can you please check the CI?

Yes, I see the problem...

cevich commented 4 years ago

...rebase onto #64 and it will solve the surface-problem. There's a more subtle problem that's the root-cause, I opened an issue and willl look at it in the next few days.

wrabcak commented 4 years ago

LGTM. THanks.