Refactor to proper abstract class

containers / udica

This repository contains a tool for generating SELinux security profiles for containers

GNU General Public License v3.0

488 stars 47 forks source link

Refactor to proper abstract class #77

Closed MartinBasti closed 4 years ago

MartinBasti commented 4 years ago

EngineHelper is an abstract class and should be treated like abstract class using python stdlib tools

Signed-off-by: Martin Bašti mbasti@redhat.com

MartinBasti commented 4 years ago

While the change looks appropriate, seems that it's failing the format checks. You can run make format locally to see what's up, or just do make format to get the tool to format this for you.

It's fixed in PR #76 ; once that PR is merged I'll rebase. Also because this PR uses ABC, I'd limit support to py3.4+ afterwards

MartinBasti commented 4 years ago

Rebased