search

containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

pod: Do not overwrite pod state #433

Closed sameo closed 7 years ago

sameo commented 7 years ago

When setting a pod state, we don't want to overwrite its existing values by storing an empty pod state with all block and fs states unitialized.

Signed-off-by: Samuel Ortiz sameo@linux.intel.com

sameo commented 7 years ago

@amshinde @mcastelino @sboeuf Without this patch, all our block indexes with CRI-O and k8s are off by one, because we reset them to 0 after creating the pod. The pod comes with a pause container for which we export one block device. So after creation, the pod block index should be set to 1.

sameo commented 7 years ago

@amshinde Feel free to merge if all CIs pass.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 66.025% when pulling d7e32978772477a540676cc95aaf82f2dd004c9e on sameo/topic/blkindex into 13b649f0fe6b72958bd5a21d7e63f5289bb2fdb4 on master.