containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

proxy: Retry if unable to connect. #451

Closed jodh-intel closed 7 years ago

jodh-intel commented 7 years ago

If a proxy cannot be connected to, retry for a period of time until a timeout (5 seconds) is reached. Output rate-limited log messages to show connect progress when an immediate connection is not possible.

Fixes: #446.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

jodh-intel commented 7 years ago

Modelled on the theme of waitForShim().

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.6%) to 65.04% when pulling 0424842cd63dacf7b139d1e6a6bbb1d31a86451d on jodh-intel:retry-proxy-connect into 549b293b42a53402b084b55fa0578c1d398c3b1e on containers:master.

sboeuf commented 7 years ago

LGTM

Approved with PullApprove Approved with PullApprove

sboeuf commented 7 years ago

I am gonna merge it since Fedora Jenkins job is not really ready, but I don't want to delay this.