containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

vendor: Move the ciao vendoring to ciao-project #459

Closed sameo closed 6 years ago

sameo commented 7 years ago

The ciao project moved to a new github organization: github.com/ciao-project. Although they continue syncing the old 01.org repo, we should switch sooner than later.

Signed-off-by: Samuel Ortiz sameo@linux.intel.com

sameo commented 7 years ago

cc @mcastelino

sboeuf commented 7 years ago

LGTM

Approved with PullApprove Approved with PullApprove

jodh-intel commented 7 years ago

lgtm

Approved with PullApprove Approved with PullApprove

mcastelino commented 7 years ago

@sameo should we just move qemu to be under clearcontainers repo or a top level repo in ciao. We should just do it once for all. /cc @markdryan

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 64.851% when pulling dd0cdcc63131feb5a4c098e525c09d6cd3a8a375 on sameo/topic/vendor into aff9031e0f7827c18fb50a747d963783cb11c650 on master.

sameo commented 7 years ago

@mcastelino If the ciao folks are ok with it, we definitely can, yes.

markdryan commented 7 years ago

@sameo, @mcastelino Moving qemu out of ciao is on my todo list but it's going to take a little bit of time. So probably best to merge this change for now.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 64.851% when pulling 8b1ea0c7065e7a68ba395b20a77fd406ea75766b on sameo/topic/vendor into b05726778f1263c36547de7fd93da9221767397d on master.

sboeuf commented 7 years ago

@sameo @markdryan sorry I didn't follow up on this one. What do you suggest ? Should I rebase this PR so that we can get it merged ??

markdryan commented 7 years ago

rebasing sounds like a good idea. I just merged a patch from @amshinde into github.com/ciao-project/ciao/qemu this morning.

sboeuf commented 7 years ago

@markdryan I thought it was my PR.... @sameo can you rebase and re-push so that we have latest ciao version vendored in virtcontainers.

devimc commented 7 years ago

also please include a short log

sameo commented 7 years ago

rebased. @devimc There are no vendoring changes, just a rename. So the shortlog is essentially empty.