shim: Display shim PID as an int

containers / virtcontainers

A Go package for building hardware virtualized container runtimes

Apache License 2.0

139 stars 43 forks source link

shim: Display shim PID as an int #462

Closed jodh-intel closed 7 years ago

jodh-intel commented 7 years ago

Log the PID of the shim as an integer string rather than having the raw int converted into a string (with undesirable and incorrect results).

Fixes #461.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

sboeuf commented 7 years ago

LGTM

coveralls commented 7 years ago

Coverage decreased (-1.4%) to 63.466% when pulling 37ed32ef492903dbf2821549eabfa116ab718118 on jodh-intel:dont-print-shim-pid-in-chinese into b05726778f1263c36547de7fd93da9221767397d on containers:master.

jodh-intel commented 7 years ago

Something about 9 soldiers.

In other news, I hear a rumour the agent speaks Klingon :smile:

jodh-intel commented 7 years ago

Although this works, it's not the correct fix - the problem is actually with the runtimes logger.

jodh-intel commented 7 years ago

The real fix is https://github.com/clearcontainers/runtime/pull/787.

jodh-intel commented 7 years ago

Closing as no longer required due to https://github.com/clearcontainers/runtime/pull/787.