vendor: Replace ciao/qemu package

containers / virtcontainers

A Go package for building hardware virtualized container runtimes

Apache License 2.0

139 stars 43 forks source link

vendor: Replace ciao/qemu package #465

Closed sboeuf closed 7 years ago

sboeuf commented 7 years ago

This PR introduces a new package pkg/qemu inside the virtcontainers repository. This package is basically a copy of what can be found into github.com/ciao-project/ciao (only changed some names). After that, it changes the virtcontainers code (qemu implementation of the hypervisor interface) by relying onto this new package instead of ciao package. And as the last part, it completely removes the dependency on ciao.

Fixes #431

coveralls commented 7 years ago

Coverage remained the same at 63.466% when pulling 81b26538271ef3dbd27fda537e9d246d8e798e7a on sboeuf/remove_ciao_dep into adc504e4132d10e0099e06239d92aa1f9ce36941 on master.

jodh-intel commented 7 years ago

lgtm.

It would be good to establish and document a strategy to ensure our version of the code stays in sync with the original (to ensure both projects benefit from performance/reliability/security changes).

sameo commented 7 years ago

I'm fine with that as long as @markdryan is ok as well

sboeuf commented 7 years ago

After discussion with @markdryan and @mcastelino about this, we have decided that qemu package will move to its own repo somewhere else. Let's drop this PR.