containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

container: Quieten logging #467

Closed jodh-intel closed 7 years ago

jodh-intel commented 7 years ago

Change fetchContainer() to only dump the config to the log on error.

Fixes #466.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.02%) to 63.442% when pulling 5e428ccadc7532d4a8f5cfdb6ad815d356aa989d on jodh-intel:quieten-container-logging into adc504e4132d10e0099e06239d92aa1f9ce36941 on containers:master.

sboeuf commented 7 years ago

LGTM

Approved with PullApprove Approved with PullApprove

jodh-intel commented 7 years ago

Travis is failing on go "tip" due to a new GOCACHE go env var it seems (it's not present in go1.7 or go1.8):

$ make
     GOBUILD  build
initializing cache in $GOCACHE: open /home/travis/.cache/go-build/log.txt: permission denied
make: *** [build] Error 1
sameo commented 7 years ago

LGTM

Approved with PullApprove Approved with PullApprove