containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

block: Skip cold-plugging block devices. #474

Closed amshinde closed 7 years ago

amshinde commented 7 years ago

Since vfio devices cannot be hotplugged currently, we need to call atachDevices from pod.go. We can avoid cold plugging block devices with this check for now.

Fixes https://github.com/clearcontainers/runtime/issues/802

Signed-off-by: Archana Shinde archana.m.shinde@intel.com

sboeuf commented 7 years ago

It's all good !! LGTM

sameo commented 7 years ago

LGTM

Approved with PullApprove Approved with PullApprove

devimc commented 7 years ago

lgtm

jodh-intel commented 7 years ago

lgtm

Approved with PullApprove Approved with PullApprove