One proxy per vm - Githubissues

containers / virtcontainers

A Go package for building hardware virtualized container runtimes

Apache License 2.0

139 stars 43 forks source link

Closed jodh-intel closed 6 years ago

jodh-intel commented 7 years ago

proxy: Launch one proxy instance per pod

Create a proxy instance for each pod (virtual machine).

Since the proxy is now launched by virtcontainers, it is necessary to specify the path to the proxy binary in the pod configuration.

Fixes #478.

jodh-intel commented 7 years ago

sboeuf commented 7 years ago

https://github.com/clearcontainers/proxy/pull/167 has been merged, there is no blocker left for this PR.

jodh-intel commented 7 years ago

Branch updated with some simplifications... and more tests! :smile:

jodh-intel commented 7 years ago

CI is failing due to the API breakage introduced by this PR (CCProxyConfig has changed).

sboeuf commented 7 years ago

@jodh-intel then you have to submit the PR on the runtime and point this PR in your commit message.

jodh-intel commented 6 years ago

Hi @sboeuf - please can you take another look?

sboeuf commented 6 years ago

@jodh-intel yes sure, let me check that right now

jodh-intel commented 6 years ago

@sboeuf - branch updated again.

sboeuf commented 6 years ago

@jodh-intel thx, let me take a look !

sboeuf commented 6 years ago

LGTM

sboeuf commented 6 years ago

Thanks for the PR @jodh-intel, everything looks good now. @sameo could you please take a look before I merge this ?

sameo commented 6 years ago

LGTM