containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

vendor: switch to govmm #510

Closed devimc closed 6 years ago

devimc commented 6 years ago

This patch replaces ciao-project with govmm

github.com/intel/govmm/ was branched from github.com/ciao-project/ciao at commit 239f5bc3e8e5fe18e6b4df31dcd692db5692c55f.

shortlog: f565536 vhost-user: add blk device support e9e2767 vhost-user: updating comments for accuracy, rename device field 8fe5723 qemu: Add maxcpus attribute to -smp 3baa776 Add badges to the README.md file d74e3b6 Fix errcheck failures in the unit tests db60e32 Enable Travis builds 9cb47fc Add .gitignore file. a8aaf53 Add project documentation 57aafb5 Remove all references to and dependencies on ciao 27709fc Move files to the qemu folder

fixes #519

Signed-off-by: Julio Montes julio.montes@intel.com

jodh-intel commented 6 years ago

Could you add details to the commit about this transition? FWICS, https://github.com/intel/govmm/ was branched from https://github.com/ciao-project/ciao at commit 239f5bc3e8e5fe18e6b4df31dcd692db5692c55f.

In other words I think, https://github.com/ciao-project/ciao/commit/239f5bc3e8e5fe18e6b4df31dcd692db5692c55f is the branch point and that commit became https://github.com/intel/govmm/commit/367ac50fe8fb55163369b6acf0a7028b452b17c5 in the new project but we might need confirmation from @markdryan on that.

sboeuf commented 6 years ago

@mcastelino well apparently the CI passed properly on that one. LGTM

Approved with PullApprove Approved with PullApprove

mcastelino commented 6 years ago

@sboeuf I wonder how CI passed for this. when we have not switched the runtime to use this package. This begs the question what is actually happening when we run the CI with runtime here.

devimc commented 6 years ago

Ready to merge :)