agent: Add kata exec, stopContainer and killContainer.

containers / virtcontainers

A Go package for building hardware virtualized container runtimes

Apache License 2.0

139 stars 43 forks source link

agent: Add kata exec, stopContainer and killContainer. #522

Closed jodh-intel closed 6 years ago

jodh-intel commented 6 years ago

Basic kata agent implementations for exec(), stopContainer() and killContainer().

Fixes #521.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

sameo commented 6 years ago

LGTM

devimc commented 6 years ago

lgtm

jodh-intel commented 6 years ago

Branch updated fairly significantly, so this will need a re-review.

sameo commented 6 years ago

still LGTM

jodh-intel commented 6 years ago

Hi @sameo - this builds locally for me so I suspect the CI fails relate to vendoring changes.

jodh-intel commented 6 years ago

... that still need to be applied to the runtime, used in testing vc.

jodh-intel commented 6 years ago

@sameo - I'm struggling to convince dep to use the sameo/topic/kata branch rather than master for the Depends-on: runtime test re-vendor to allow this PR to pass the CI checks.

jodh-intel commented 6 years ago

Removed the commit that converted the user+group fields in Cmd from string to uint32 and raised #534 to explain why we cannot do that.

sboeuf commented 6 years ago

@jodh-intel Could you please rework this PR according to the changes introduced here: https://github.com/kata-containers/agent/pull/83 Also, I think you should open a PR against master so that we can review it and merge it into virtcontainers.

jodh-intel commented 6 years ago

Closing - replaced by #538.