containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

Add comment explaining why Cmd type must encode user and groups as strings #533

Closed jodh-intel closed 6 years ago

jodh-intel commented 6 years ago

The Cmd type encodes the user and group details that the workload will be run as.

It currently encodes those values as strings, although since the OCI spec and the Kata gRPC protocol encode such values as integers, we would ideally like to change Cmd so that the user and group details are also encoded as integer values (with a conversion to strings for sending such details to hyperstart which uses string types for them).

However, we've realised this isn't possible so add a comment explaining why they are encoded as strings and must remain that way.

See: