containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

mounts: Fix bug while checking if /dev was bind-mounted #539

Closed amshinde closed 6 years ago

amshinde commented 6 years ago

There was a bug in the way we were checking if /dev was bindmounted from the host.

Signed-off-by: Archana Shinde archana.m.shinde@intel.com

amshinde commented 6 years ago

cc @egernst

sboeuf commented 6 years ago

LGTM

Approved with PullApprove Approved with PullApprove

jodh-intel commented 6 years ago

lgtm

Approved with PullApprove Approved with PullApprove

sameo commented 6 years ago

LGTM

Approved with PullApprove Approved with PullApprove

jodh-intel commented 6 years ago

Coveralls is "stuck" again (https://github.com/clearcontainers/jenkins/issues/9), but has actually run if you look at the 16.04 CI build log: https://coveralls.io/jobs/32568132.

It claims coverage fell by 3.5% but clearly it's lying, so merging.