containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

qemu: adjust QMP naming to avoid non-unique truncation #553

Closed egernst closed 6 years ago

egernst commented 6 years ago

The full name of the QMP monitor and control sockets was well beyond the 107 character limit, resulting in the full name to be truncated during creation. As a result, only a single socket was created.

Instead of creating a socket at

/-, create it at /-, keeping as much of the unique socket name as feasible. Also, to reduce truncation the ".sock" from the socket names were removed. Fixes #552 Signed-off-by: Eric Ernst
egernst commented 6 years ago

@sboeuf -- not ideal, but much safer, imo.

sboeuf commented 6 years ago

@egernst agreed

sboeuf commented 6 years ago

LGTM

sameo commented 6 years ago

LGTM

Approved with PullApprove Approved with PullApprove