containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

Start shims after creating containers #575

Closed sameo closed 6 years ago

sameo commented 6 years ago

Right now the virtcontainers core code explictly starts shims as soon as possible, regardless of the shim implementation being able to handle non existing containers or not.

This PR reorders that sequence and guarantees that shims will not be started before their corresponding container process is not started.

Now we have:

sameo commented 6 years ago

@sboeuf This is an attempt at reorganizing the code for having the shims only started after the container is created on the guest, in order to avoid the SIGUSR1 synchronization.

sameo commented 6 years ago

This should pass unit testing now, at least :-/

sameo commented 6 years ago

simple integration tests are failing, will fix those today as I can reproduce on my local env.

sameo commented 6 years ago

Basic integration tests now work with kata and CC with that PR. I'd say it's ready for review @sboeuf @jodh-intel

sboeuf commented 6 years ago

@sameo cool, I'll review this tomorrow.

sboeuf commented 6 years ago

LGTM Let's wait for the last patch fixing the docker exec command and we'll be good to merge this. As a follow up, I'll raise a PR implementing what's described here

sameo commented 6 years ago

coverall says we're at 63% with that PR...merging.