kata_agent: Unmount properly the container

containers / virtcontainers

A Go package for building hardware virtualized container runtimes

Apache License 2.0

139 stars 43 forks source link

kata_agent: Unmount properly the container #587

Closed sboeuf closed 6 years ago

sboeuf commented 6 years ago

Only the unmounting of the container rootfs was performed, leaving behind all the other mounts related to the container.

Fixes #562

Signed-off-by: Sebastien Boeuf sebastien.boeuf@intel.com

sboeuf commented 6 years ago

cc @sameo @jodh-intel

jodh-intel commented 6 years ago

Good catch. Clearly we need a test for this (in https://github.com/clearcontainers/tests maybe?)

The change itself...

lgtm

grahamwhaley commented 6 years ago

I think @chavafg had a plan to add some checks similar to the ones that can be found here: https://github.com/clearcontainers/tests/blob/master/integration/stability/soak_parallel_rm.sh#L182 to some, or maybe all?, of the tests. If we add (or have) an 'init()' and 'teardown()' pair of functions already, then the tests can be added there.

Once we have the current tests running stably with kata, then we should rework that soak_parallel test to understand kata, and then give it a spin...

sameo commented 6 years ago

LGTM