kata_agent: Enable devicemapper support for block devices

containers / virtcontainers

A Go package for building hardware virtualized container runtimes

Apache License 2.0

139 stars 43 forks source link

kata_agent: Enable devicemapper support for block devices #626

Closed sboeuf closed 6 years ago

sboeuf commented 6 years ago

This PR enables the support for Kata with block devices. It enables it both for rootfs being passed as a block device from devicemapper, and for block devices being passed through the VM to the container.

Fixes #622

sboeuf commented 6 years ago

Depends on https://github.com/kata-containers/agent/pull/133

sboeuf commented 6 years ago

cc @sameo @jodh-intel

sameo commented 6 years ago

LGTM

sameo commented 6 years ago

@sboeuf We should probably wait until kata-containers/agent#133 gets merged before taking that one.

sboeuf commented 6 years ago

@sameo yes I agree since it depends on it, and I don't want to merge this because the agent PR might change based on comments. I have added do-not-merge label just to make sure we don't forget !

sboeuf commented 6 years ago

@amshinde PR updated, PTAL

sboeuf commented 6 years ago

I have checked this PR with latest version of https://github.com/kata-containers/agent/pull/133, and all cases works as expected:

Overlay rootfs with no device passthrough
Overlay rootfs with block device passthrough
Devicemapper rootfs with no device passthrough
Devicemapper rootfs with block device passthrough

We'll need a follow up PR to be able to support block devices with SCSI, but we should move forward and get this one merged first.

sboeuf commented 6 years ago

https://github.com/kata-containers/agent/pull/133 has been merged. @grahamwhaley @jodh-intel please merge this if the CI is all green